Apt: Write repo key to own file; require puppetlabs/apt 10.X#243
Merged
TheMeier merged 1 commit intovoxpupuli:masterfrom Aug 16, 2025
Merged
Apt: Write repo key to own file; require puppetlabs/apt 10.X#243TheMeier merged 1 commit intovoxpupuli:masterfrom
TheMeier merged 1 commit intovoxpupuli:masterfrom
Conversation
bastelfreak
force-pushed
the
241
branch
2 times, most recently
from
22fa3e8 to
dc46a05
Compare
bastelfreak
changed the title
Contributor
|
Should this be marked as backward-incompatible because of raising min version for the apt dep? |
Member
Author
|
I am really unsure about it :( |
TheMeier
approved these changes
Jul 16, 2025
Contributor
|
because of #246 let's just mark it breaking and get on with it |
TheMeier
added
the
backwards-incompatible
Without setting the name attribute, the key will be added to the global /etc/apt/trusted.gpg keyring. That is deprecated. Also we need to ensure `id` isn't set, otherwise apt-key might be invoked to fetch the key from a keyserver. Fixes voxpupuli#241
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without setting the name attribute, the key will be added to the global
/etc/apt/trusted.gpg keyring. That is deprecated. Also we need to ensure
idisn't set, otherwise apt-key might be invoked to fetch the key froma keyserver.
Fixes #241